Re: [misc] [PATCH] Default (white) as foreground colour
- Date: Thu, 7 Dec 2017 10:09:39 +0100
- From: Lars Henriksen <LarsHenriksen@xxxxxxxxxx>
- Subject: Re: [misc] [PATCH] Default (white) as foreground colour
On Thu, Dec 07, 2017 at 09:05:12AM +0100, Lukas Fleischer wrote:
> On Wed, 06 Dec 2017 at 11:23:36, Lars Henriksen wrote:
> > [...]
> > > I like the overall idea of this patch. However, is there any reason for
> > > making white a special case as well? We cannot assume that white is the
> > > "default foreground color". I, myself, am using a black on white
> > > terminal and others might be using green on black or even more exotic
> > > combinations.
> > Yes, you are right. This requires more testing on my part. I really should
> > have tried this out with other default values than white on black, and
> > white should not be treated differently.
> > Do you use default on default with the default values determined by the
> > terminal emulator?
> Nope, I usually use blue on default (i.e. blue on white). I can still
> test "default on default" with your patch applied, of course.
Thanks. I have amended the patch and will submit it later.
It seems to work like intended, although not quite as I expected. When turning
on A_BOLD for the colour pair (default fg, default bg), I had expected the
colour, whatever it is, to change to a brighter version. Not so in my
environment which is putty/Linux. Putty has suppport for setting colours,
default and otherwise. You can set the the default foreground/background and
also default bold foreground/background. These are independent of each other.
The effect of A_BOLD is that putty's default bold foreground is applied.
I wonder how curses handle attributes and default colours?