Re: [bugs] [PATCH] Fix integer parsing
- Date: Tue, 5 Dec 2017 14:51:00 +0100
- From: Lars Henriksen <LarsHenriksen@xxxxxxxxxx>
- Subject: Re: [bugs] [PATCH] Fix integer parsing
On Tue, Dec 05, 2017 at 08:36:04AM +0100, Lukas Fleischer wrote:
> Not quite. Having a function called is_all_digit() return true on the
> empty string is the only sensible behavior. However...
> I am fine with changing the semantics as you suggested and rename the
> function to is_numeric() (or any other name you like which describes the
> new behavior).
Leave it as it is, but add the test for non-emptyness in config_parse_int().
Elsewhere, I believe, it is ensured in other ways.