Re: [bugs] [PATCH] Check for the year span 1902-2037.
- Date: Thu, 23 Nov 2017 08:55:12 +0100
- From: Lukas Fleischer <lfleischer@xxxxxxxxxxxx>
- Subject: Re: [bugs] [PATCH] Check for the year span 1902-2037.
On Sun, 19 Nov 2017 at 22:51:57, Lars Henriksen wrote:
> Reintroduce year check for systems with a 32-bit time_t type.
> Remove the lower limit (1902) for systems with a 64-bit time_t.
> This limits movements in the calendar (for 32-bit systems) and in no way
> ensures constistency of data.
I agree with the patch, I am curious about what you mean by "limits
movements in the calendar (for 32-bit systems)", though...
> Commit a12833e removed the upper limit (2037) on dates but left the lower
> limit (1902). It did not ensure the support of the target system.
I'd appreciate if you could drop the period from the subject line and
sign-off future patches :)
> src/calcurse.h | 11 ++++++++---
> src/ui-calendar.c | 24 ++++++++++++++++++------
> src/utils.c | 14 ++++++++------
> 3 files changed, 34 insertions(+), 15 deletions(-)
Merged into pu, thanks!